From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/mxsfb/lcdif: use dev_err_probe() consistently in lcdif_attach_bridge Date: Sun, 22 Mar 2026 03:48:37 +1000 Message-ID: In-Reply-To: <20260320-drm-lcdif-dbanc-v1-3-479a04133e70@bootlin.com> References: <20260320-drm-lcdif-dbanc-v1-0-479a04133e70@bootlin.com> <20260320-drm-lcdif-dbanc-v1-3-479a04133e70@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Straightforward cleanup. Using `dev_err_probe()` for all error paths is the right approach. One minor observation: ```c if (!encoder) return dev_err_probe(dev, -ENOMEM, "Failed to allocate encoder\n"); ``` Using `dev_err_probe()` for `-ENOMEM` is slightly unusual since `-ENOMEM` is never `-EPROBE_DEFER`, but it's acceptable for code consistency and still prints the error message correctly. --- Generated by Claude Code Patch Reviewer