public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: sm6125-xiaomi-laurel-sprout: Enable MDSS and add panel
Date: Sun, 22 Mar 2026 03:41:50 +1000	[thread overview]
Message-ID: <review-patch3-20260320-panel-patches-v7-3-3eaefc4b3878@gmail.com> (raw)
In-Reply-To: <20260320-panel-patches-v7-3-3eaefc4b3878@gmail.com>

Patch Review

1. **`panel_vci_3p0` voltage mismatch** (lines 99-110 of the DTS): The regulator node is named `panel_vci_3p0` and `regulator-name` is `"panel_vci_3p0"`, implying 3.0V, but the actual voltage is set to **1800000 µV (1.8V)**:
   ```
   panel_vci_3p0: regulator-panel-vci {
       regulator-name = "panel_vci_3p0";
       regulator-min-microvolt = <1800000>;
       regulator-max-microvolt = <1800000>;
   ```
   This is likely a bug — either the voltage should be 3000000 (matching the name), or the name should be changed to `panel_vci_1p8`. VCI supplies for Samsung AMOLED panels are typically 3.0V. **This should be clarified/fixed.**

2. **No `vin-supply` on `panel_vci_3p0`**: The `panel_vdd_1p8` regulator has `vin-supply = <&vreg_l9a>`, but `panel_vci_3p0` has no `vin-supply`. This may be intentional if it's directly driven by the GPIO, but worth confirming.

3. **Extra blank line** (between `&mdss_dsi0_out` and `&mdss_dsi0_phy` blocks): There's a double blank line at the junction. Very minor style nit.

4. **`regulator-boot-on` on both regulators**: This keeps regulators enabled during boot, preventing screen flicker. Reasonable for a display panel.

5. **`reset-gpios` polarity**: The panel node uses `GPIO_ACTIVE_LOW`, and the driver's reset sequence asserts with `gpiod_set_value_cansleep(ctx->reset_gpio, 0)` → deassert, `1` → assert. With `GPIOD_OUT_HIGH` at probe (asserting reset = holding panel in reset), then the prepare sequence deasserts, pulses assert, deasserts. This is consistent — the GPIO descriptor layer handles the inversion. Fine.

**Summary**: The main actionable item is the `panel_vci_3p0` regulator voltage — the name says 3.0V but the value is 1.8V. This should be resolved before merging.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-21 17:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-20 14:41 [PATCH v7 0/3] Add support for the Samsung S6E8FC0 DSI and M1906F9 display panel Yedaya Katsman
2026-03-20 14:41 ` [PATCH v7 1/3] dt-bindings: display: panel: Add Samsung S6E8FC0-M1906F9 Yedaya Katsman
2026-03-21 17:41   ` Claude review: " Claude Code Review Bot
2026-03-20 14:41 ` [PATCH v7 2/3] drm: panel: Add Samsung S6E8FC0 DSI controller for M1906F9 panel Yedaya Katsman
2026-03-21 17:41   ` Claude review: " Claude Code Review Bot
2026-03-20 14:41 ` [PATCH v7 3/3] arm64: dts: qcom: sm6125-xiaomi-laurel-sprout: Enable MDSS and add panel Yedaya Katsman
2026-03-21 17:41   ` Claude Code Review Bot [this message]
2026-03-21 17:41 ` Claude review: Add support for the Samsung S6E8FC0 DSI and M1906F9 display panel Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-14 21:46 [PATCH v4 0/3] Add support for the Samsung S6E8FCO " Yedaya Katsman
2026-03-14 21:46 ` [PATCH v4 3/3] arm64: dts: qcom: sm6125-xiaomi-laurel-sprout: Enable MDSS and add panel Yedaya Katsman
2026-03-16  1:54   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260320-panel-patches-v7-3-3eaefc4b3878@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox