From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panfrost: Add bus_ace optional clock support for RZ/G2L
Date: Sun, 22 Mar 2026 03:29:03 +1000 [thread overview]
Message-ID: <review-patch3-20260320164158.487406-4-biju.das.jz@bp.renesas.com> (raw)
In-Reply-To: <20260320164158.487406-4-biju.das.jz@bp.renesas.com>
Patch Review
This adds an optional `bus_ace` clock alongside the existing `bus` clock. The init/fini paths look correct. However, there is an issue in the runtime resume error handling and a question about the runtime resume enable path.
**Issue: bus_ace_clock enable is gated by GPU_PM_RT but only conditionally needed**
In `panfrost_device_runtime_resume()`, the new `clk_enable(pfdev->bus_ace_clock)` call is placed *inside* the `if (pfdev->comp->pm_features & BIT(GPU_PM_RT))` block:
```c
if (pfdev->comp->pm_features & BIT(GPU_PM_RT)) {
...
ret = clk_enable(pfdev->bus_clock);
if (ret)
goto err_bus_clk;
ret = clk_enable(pfdev->bus_ace_clock);
if (ret)
goto err_bus_ace_clk;
}
```
This is fine because `clk_enable(NULL)` returns 0, and the clock is optional, so it will be NULL on platforms that don't need it. However, the commit message says the clock is needed for RZ/G2L, yet looking at the existing tree, RZ/G2L (`r9a07g044`) uses `default_pm_rt_data` — so the `GPU_PM_RT` gate is the correct place. This seems consistent.
**Issue: `panfrost_device_resume`/`panfrost_device_suspend` (`GPU_PM_CLK_DIS` path) not updated**
The `bus_ace_clock` is not handled in `panfrost_device_resume()` and `panfrost_device_suspend()` which manage clocks for the `GPU_PM_CLK_DIS` feature. If any future SoC with `bus_ace_clock` also uses `GPU_PM_CLK_DIS`, the clock would not be properly managed during system suspend/resume. For current hardware this is not a problem since RZ/G2L only uses `GPU_PM_RT`, but it could be worth a note or a follow-up.
**The runtime resume/suspend paths look correct** for the current use case. The error cleanup properly disables `bus_clock` before falling through to `err_bus_clk`.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-21 17:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 16:41 [PATCH v2 0/4] Add RZ/G3L GFX support Biju
2026-03-20 16:41 ` [PATCH v2 1/4] dt-bindings: gpu: mali-bifrost: Add compatible for RZ/G3L SoC Biju
2026-03-21 17:29 ` Claude review: " Claude Code Review Bot
2026-03-20 16:41 ` [PATCH v2 2/4] drm/panfrost: Drop redundant optional clock checks in runtime PM Biju
2026-03-20 21:19 ` Adrián Larumbe
2026-03-20 21:32 ` Biju Das
2026-03-21 14:16 ` Biju Das
2026-03-21 17:29 ` Claude review: " Claude Code Review Bot
2026-03-20 16:41 ` [PATCH v2 3/4] drm/panfrost: Add bus_ace optional clock support for RZ/G2L Biju
2026-03-20 21:15 ` Adrián Larumbe
2026-03-21 17:29 ` Claude Code Review Bot [this message]
2026-03-20 16:41 ` [PATCH v2 4/4] drm/panfrost: Add GPU_PM_RT support for RZ/G3L SoC Biju
2026-03-20 21:14 ` Adrián Larumbe
2026-03-21 17:29 ` Claude review: " Claude Code Review Bot
2026-03-21 17:29 ` Claude review: Add RZ/G3L GFX support Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-04 13:48 [PATCH 0/4] " Biju
2026-03-04 13:48 ` [PATCH 3/4] drm/panfrost: Add bus_ace optional clock support for RZ/G2L Biju
2026-03-05 3:22 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260320164158.487406-4-biju.das.jz@bp.renesas.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox