From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: rust: dma: add zeroed constructor to `Coherent` Date: Sun, 22 Mar 2026 03:23:43 +1000 Message-ID: In-Reply-To: <20260320194626.36263-4-dakr@kernel.org> References: <20260320194626.36263-1-dakr@kernel.org> <20260320194626.36263-4-dakr@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Adds `zeroed`, `zeroed_with_attrs`, `zeroed_slice`, and `zeroed_slice_with_= attrs`. All delegate to the private `alloc_with_attrs` / `alloc_slice_with_= attrs` with `__GFP_ZERO` ORed into the flags. **Double zeroing concern**: If a caller passes `GFP_KERNEL | __GFP_ZERO` to= `zeroed()`, the flag will be ORed again (no-op but semantically redundant)= . The naming makes this clear enough =E2=80=94 callers of `zeroed` shouldn'= t also pass `__GFP_ZERO`. The sample driver update (`rust_dma.rs`) correctly converts from the old `a= lloc_coherent` to `zeroed_slice`. Clean. --- Generated by Claude Code Patch Reviewer