From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/dsi: rename MSM8998 DSI version from V2_2_0 to V2_0_0
Date: Sun, 22 Mar 2026 03:12:28 +1000 [thread overview]
Message-ID: <review-patch3-20260321-dsi-rgb101010-support-v4-3-eb28ecebbfe8@pm.me> (raw)
In-Reply-To: <20260321-dsi-rgb101010-support-v4-3-eb28ecebbfe8@pm.me>
Patch Review
The old define:
```c
#define MSM_DSI_6G_VER_MINOR_V2_2_0 0x20000000
```
was incorrectly named — `0x20000000` decodes to v2.0.0, not v2.2.0. The rename to `V2_0_0` and reordering to maintain version sorting is correct:
```c
#define MSM_DSI_6G_VER_MINOR_V2_0_0 0x20000000
#define MSM_DSI_6G_VER_MINOR_V2_1_0 0x20010000
```
The `dsi_cfg.c` table entry is also reordered to match. The `Fixes:` tag is appropriate since the original commit introduced the wrong name.
**No issues.** Clean cosmetic fix.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-21 17:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 7:52 [PATCH v4 0/5] drm/msm: add RGB101010 pixel format and fix 10-bit DSC timing Alexander Koskovich
2026-03-21 7:52 ` [PATCH v4 1/5] drm/mipi-dsi: add RGB101010 pixel format Alexander Koskovich
2026-03-21 17:12 ` Claude review: " Claude Code Review Bot
2026-03-21 7:52 ` [PATCH v4 2/5] drm/meson: handle RGB101010 in format switches Alexander Koskovich
2026-03-21 9:37 ` Neil Armstrong
2026-03-21 17:12 ` Claude review: " Claude Code Review Bot
2026-03-21 7:52 ` [PATCH v4 3/5] drm/msm/dsi: rename MSM8998 DSI version from V2_2_0 to V2_0_0 Alexander Koskovich
2026-03-21 17:12 ` Claude Code Review Bot [this message]
2026-03-21 7:52 ` [PATCH v4 4/5] drm/msm/dsi: add DSI version >= comparison helper Alexander Koskovich
2026-03-21 17:12 ` Claude review: " Claude Code Review Bot
2026-03-21 7:52 ` [PATCH v4 5/5] drm/msm/dsi: Add support for RGB101010 pixel format Alexander Koskovich
2026-03-21 17:12 ` Claude review: " Claude Code Review Bot
2026-03-21 17:12 ` Claude review: drm/msm: add RGB101010 pixel format and fix 10-bit DSC timing Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-19 11:57 [PATCH v3 0/4] " Alexander Koskovich
2026-03-19 11:57 ` [PATCH v3 1/4] drm/msm/dsi: rename MSM8998 DSI version from V2_2_0 to V2_0_0 Alexander Koskovich
2026-03-21 18:21 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260321-dsi-rgb101010-support-v4-3-eb28ecebbfe8@pm.me \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox