From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tyr: Set interconnect coherency during probe Date: Wed, 25 Mar 2026 07:08:42 +1000 Message-ID: In-Reply-To: <20260323-b4-tyr-use-register-macro-v3-v3-3-a87daf9e4701@collabora.com> References: <20260323-b4-tyr-use-register-macro-v3-v3-0-a87daf9e4701@collabora.com> <20260323-b4-tyr-use-register-macro-v3-v3-3-a87daf9e4701@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Writes `NO_COHERENCY` to `COHERENCY_ENABLE` during probe, then reads it bac= k in `GpuInfo::new()`. The FIXME comment about `device_get_dma_attr()` is a= ppropriate =E2=80=93 this is a known limitation. The `CoherencyMode::None` variant uses value 31 (from `DRM_PANTHOR_GPU_COHE= RENCY_NONE`). Writing 31 into a 32-bit field and reading it back should wor= k correctly. --- Generated by Claude Code Patch Reviewer