From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/a6xx: Correct OOB usage
Date: Wed, 25 Mar 2026 07:32:08 +1000
Message-ID: <review-patch3-20260324-a8xx-gpu-batch2-v1-3-fc95b8d9c017@oss.qualcomm.com>
In-Reply-To: <20260324-a8xx-gpu-batch2-v1-3-fc95b8d9c017@oss.qualcomm.com>
References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> <20260324-a8xx-gpu-batch2-v1-3-fc95b8d9c017@oss.qualcomm.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

Moves the sysprof OOB setup from `a6xx_gmu_resume()` to `hw_init()` to avoi=
d confusing the GMU firmware state during resume.

**Minor concern:** In `a6xx_gmu.c`, the removal leaves:
```c
out:
	/* On failure, shut down the GMU to leave it in a good state */
	if (ret) {
```
There's now a blank line before `out:`, which is fine stylistically but wor=
th noting the label now follows directly after the set_initial_freq call wi=
th no intervening code.

The a8xx copy in `a8xx_gpu.c` adds the same pattern =E2=80=94 both check `!=
ret` correctly.

---
Generated by Claude Code Patch Reviewer