From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: phy: qcom-uniphy: add more registers from display PHYs Date: Wed, 25 Mar 2026 07:14:42 +1000 Message-ID: In-Reply-To: <20260324-fd-hdmi-phy-v7-3-b41dde8d83b8@oss.qualcomm.com> References: <20260324-fd-hdmi-phy-v7-0-b41dde8d83b8@oss.qualcomm.com> <20260324-fd-hdmi-phy-v7-3-b41dde8d83b8@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds additional UniPHY PLL register defines and bitfield definitions used by the MSM8974 HDMI PHY. Clean and well-organized with proper `FIELD_PREP`/`FIELD_GET` macros. **Minor:** Some register names like `UNIPHY_PLL_CTRL_42` through `UNIPHY_PLL_CTRL_54` use numeric suffixes rather than descriptive names. These are presumably unnamed in the documentation, so this is acceptable but worth noting if better names are known. --- Generated by Claude Code Patch Reviewer