From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/mxsfb/lcdif: use dev_err_probe() consistently in lcdif_attach_bridge Date: Tue, 31 Mar 2026 16:54:43 +1000 Message-ID: In-Reply-To: <20260330-drm-lcdif-dbanc-v2-3-c7f2af536a24@bootlin.com> References: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> <20260330-drm-lcdif-dbanc-v2-3-c7f2af536a24@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Straightforward conversion of `dev_err()` + `return` to `dev_err_probe()`. = One minor nit: Using `dev_err_probe()` for `-ENOMEM` from `devm_kzalloc()` is a bit unusua= l =E2=80=94 `-ENOMEM` is never `-EPROBE_DEFER`, so the deferred-probe track= ing aspect of `dev_err_probe()` doesn't add value here. It's not wrong, jus= t slightly unconventional. The consistency argument in the commit message i= s fair enough. --- Generated by Claude Code Patch Reviewer