From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/imagination: Skip check on paired job fence during job submission Date: Tue, 31 Mar 2026 17:33:24 +1000 Message-ID: In-Reply-To: <20260330-job-submission-fixes-cleanup-v1-3-7de8c09cef8c@imgtec.com> References: <20260330-job-submission-fixes-cleanup-v1-0-7de8c09cef8c@imgtec.com> <20260330-job-submission-fixes-cleanup-v1-3-7de8c09cef8c@imgtec.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status**: Good cleanup. Removes the `is_paired_job_fence()` check from `pvr_queue_submit_job_to_cccb()`, because the loop already calls `to_pvr_queue_job_fence()` which returns NULL for the paired job fence (since it has no parent/UFO backing yet). The comment added explaining *why* this works is valuable: ```c + /* + * The loop above will only process dependencies backed by a UFO i.e. with + * a valid parent fence assigned, but the paired job dependency won't have + * one until both jobs have been submitted. Access the parent fence directly + * here instead, submitting it last as partial render fence. + */ ``` **No issues.** This is strictly removing dead code with a good explanation. --- Generated by Claude Code Patch Reviewer