From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/amdxdna: Create common PSP interfaces for AIE2 and AIE4 Date: Tue, 31 Mar 2026 17:05:09 +1000 Message-ID: In-Reply-To: <20260330163705.3153647-4-lizhi.hou@amd.com> References: <20260330163705.3153647-1-lizhi.hou@amd.com> <20260330163705.3153647-4-lizhi.hou@amd.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Renames `aie2_psp.c` =E2=86=92 `aie_psp.c` and moves PSP types/declarations= into `aie.h`. **Issue 1 =E2=80=94 Copyright year change removes history:** ```c -// Copyright (C) 2022-2024, Advanced Micro Devices, Inc. +// Copyright (C) 2026, Advanced Micro Devices, Inc. ``` The original copyright range (2022-2024) is replaced with just 2026. This l= oses the attribution history. Should be `2022-2026`. **Issue 2 =E2=80=94 `psp_conf` zero-initialization:** ```c - struct psp_config psp_conf; + struct psp_config psp_conf =3D { 0 }; ``` Good =E2=80=94 needed because `psp_config` now has more fields (`certfw_buf= `, `certfw_size`, `arg2_mask`, `notify_val`). But `arg2_mask` and `notify_v= al` are not set in this patch (they're added in patch 4), so `arg2_mask =3D= 0` and `notify_val =3D 0` would be used if PSP runs before patch 4 is appl= ied. This means the series has a bisection issue =E2=80=94 patches 3 alone = would break PSP because `notify_val =3D 0` means the interrupt never fires. --- Generated by Claude Code Patch Reviewer