From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/atomic: Call complete_signaling only if prepare_signaling is done Date: Wed, 01 Apr 2026 07:55:27 +1000 Message-ID: In-Reply-To: <20260331-atomic-v11-3-6a1df7ec5af8@intel.com> References: <20260331-atomic-v11-0-6a1df7ec5af8@intel.com> <20260331-atomic-v11-3-6a1df7ec5af8@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review ```c - complete_signaling(dev, state, fence_state, num_fences, !ret); + if (num_fences) + complete_signaling(dev, state, fence_state, num_fences, !ret); ``` This is needed because patch 4 moves the state allocation earlier, so error paths now reach `out:` before `prepare_signaling` runs. The check is reasonable since `num_fences` is now initialized to 0. However, `complete_signaling` also handles cleanup of `crtc_state->event` when `install_fds` is false (error path). Skipping it entirely when `num_fences == 0` could miss that event cleanup if we've partially set up state but never called `prepare_signaling`. Looking at the code, events are only set up inside `prepare_signaling`, so this should be safe. But a comment explaining why this is safe would help. --- --- Generated by Claude Code Patch Reviewer