From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: simple-bridge: Add support for MStar TSUMU88ADT3-LF-1
Date: Sun, 12 Apr 2026 14:40:55 +1000
Message-ID: <review-patch3-20260406073930.24662-4-clamor95@gmail.com>
In-Reply-To: <20260406073930.24662-4-clamor95@gmail.com>
References: <20260406073930.24662-1-clamor95@gmail.com> <20260406073930.24662-4-clamor95@gmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Author:** Maxim Schwalm, submitted by Svyatoslav Ryhel

Adds the `of_device_id` entry to the simple-bridge driver:

```c
	}, {
		.compatible =3D "mstar,tsumu88adt3-lf-1",
		.data =3D &(const struct simple_bridge_info) {
			.connector_type =3D DRM_MODE_CONNECTOR_HDMIA,
		},
```

**Review:**

- **Alphabetical ordering** in the match table is correct: `asl-tek,cs5263`=
 =E2=86=92 `mstar,tsumu88adt3-lf-1` =E2=86=92 `parade,ps185hdm`.
- **Connector type** `DRM_MODE_CONNECTOR_HDMIA` is appropriate for an HDMI =
bridge, matching the cover letter description.
- **No `.timings`** field is set, which is the same pattern as other HDMI b=
ridges in the table (e.g., `algoltek,ag6311`, `parade,ps185hdm`). The `defa=
ult_bridge_timings` are only used for VGA DACs, so this is correct.
- The compound literal `&(const struct simple_bridge_info)` pattern follows=
 the existing code exactly.
- Has Reviewed-by from Robert Foss.

No issues.

---
Generated by Claude Code Patch Reviewer