From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/doc: Document DRM_WEDGE_RECOVERY_COLD_RESET recovery method
Date: Sun, 12 Apr 2026 14:32:33 +1000
Message-ID: <review-patch3-20260406142325.157035-9-mallesh.koujalagi@intel.com>
In-Reply-To: <20260406142325.157035-9-mallesh.koujalagi@intel.com>
References: <20260406142325.157035-6-mallesh.koujalagi@intel.com> <20260406142325.157035-9-mallesh.koujalagi@intel.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Recovery script is incomplete:**

```sh
    else
	echo "No slot found"
    fi
```

When no PCI slot is found for power-cycling, the script just prints "No slo=
t found" and exits with success. For a recovery example, this is misleading=
 =E2=80=94 the user has no recovery path. At minimum it should suggest IPMI=
/BMC power cycling or exit with a non-zero status.

**Udev rule quoting:**

```
SUBSYSTEM=3D=3D"drm", ENV{WEDGED}=3D=3D"cold-reset", DEVPATH=3D=3D"*/drm/ca=
rd[0-9]",
RUN+=3D"/path/to/cold-reset.sh $env{DEVPATH}"
```

The DEVPATH glob `card[0-9]` only matches single-digit card numbers. For co=
nsistency with other examples in the doc, or for systems with 10+ GPUs, use=
 `card[0-9]*`.

**Cold Reset Recovery section placement:**

The "Cold Reset Recovery" section is placed before "Vendor Specific Recover=
y" in the document, but BIT(4) comes after BIT(3). Consider placing it afte=
r the vendor-specific section to match the severity ordering, or explicitly=
 document the ordering.

---
Generated by Claude Code Patch Reviewer