From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: bridge: Add Cadence MHDP8501 Date: Sun, 12 Apr 2026 13:34:45 +1000 Message-ID: In-Reply-To: <20260407-dcss-hdmi-upstreaming-v21-3-4681070ab82f@oss.nxp.com> References: <20260407-dcss-hdmi-upstreaming-v21-0-4681070ab82f@oss.nxp.com> <20260407-dcss-hdmi-upstreaming-v21-3-4681070ab82f@oss.nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **`cdns,bridge-type` property concern:** ```yaml cdns,bridge-type: $ref: /schemas/types.yaml#/definitions/uint32 enum: [0, 1] description: | Type of bridge output: 0: DisplayPort 1: HDMI ``` Using a vendor-specific integer property to specify bridge type is question= able. The connector type should ideally be determined by the downstream por= t's compatible (e.g., `hdmi-connector` vs `dp-connector`). The cover letter= mentions "I couldn't find another way to do it..." =E2=80=94 the bridge sh= ould be able to discover this from its output port graph connection. This w= as also flagged in previous reviews by Dmitry. **Missing `Reviewed-by` tags**: No dt-bindings maintainer review tag. Krzys= ztof's tag was dropped since a new property was added. **Nit in example DTS:** ```yaml phys =3D <&mdhp_phy>; ``` The phandle `mdhp_phy` has a typo (should be `mhdp_phy`, matching standard = MHDP naming). This same typo propagates to patch 7. --- Generated by Claude Code Patch Reviewer