Claude review: phy: freescale: Add DisplayPort/HDMI Combo-PHY driver for i.MX8MQ

Claude Code Review Bot
2026-04-12T03:34:46Z

Patch Review

**Resource mapping should use `devm_platform_ioremap_resource()`:**
```c
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res)
return -ENODEV;
cdns_phy->regs = devm_ioremap(dev, res->start, resource_size(res));
```
This is the old pattern. Modern drivers use the simpler `devm_platform_ioremap_resource(pdev, 0)` which handles the NULL check and does `devm_ioremap_resource` (which also does request_region). The same issue exists in the bridge probe in patch 4.

**`hdptx_clk_enable` error handling:**
```c
ret = hdptx_clk_enable(cdns_phy);
if (ret)
return -EINVAL;
```
This discards the actual error code from `hdptx_clk_enable`. Should be `return ret;`.

**Missing `phy_exit()` on error and remove paths**: `phy_init()` is not called in the PHY driver itself (that's the consumer's responsibility), so this is fine, but the clocks enabled in probe are never disabled — `devm_clk_get_enabled` handles this via devm, so it's correct.

**Large PLL configuration tables**: The 32-entry `pixel_clk_output_ctrl_table` and 15-entry `pixel_clk_output_pll_table` are quite large. Consider whether they belong in a separate data file, but this is a style preference.

---
Generated by Claude Code Patch Reviewer