From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/mxsfb/lcdif: use dev_err_probe() consistently in lcdif_attach_bridge Date: Sun, 12 Apr 2026 13:37:34 +1000 Message-ID: In-Reply-To: <20260407-drm-lcdif-dbanc-v4-3-247a16e61ef9@bootlin.com> References: <20260407-drm-lcdif-dbanc-v4-0-247a16e61ef9@bootlin.com> <20260407-drm-lcdif-dbanc-v4-3-247a16e61ef9@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Converts remaining `dev_err()` + `return` patterns to `dev_err_probe()`. One minor style note: ```c + if (!encoder) + return dev_err_probe(dev, -ENOMEM, + "Failed to allocate encoder for endpoint%u\n", + of_ep.id); ``` Using `dev_err_probe()` with `-ENOMEM` is slightly unusual since `-ENOMEM` is never a deferred probe case, but it's not wrong -- `dev_err_probe()` works for any error and the consistency argument is valid. No issues. --- --- Generated by Claude Code Patch Reviewer