From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: clk: qcom: common: ensure runtime PM suspend completes on probe Date: Sun, 12 Apr 2026 13:46:55 +1000 Message-ID: In-Reply-To: <20260407-gfx-clk-fixes-v1-3-4bb5583a5054@oss.qualcomm.com> References: <20260407-gfx-clk-fixes-v1-0-4bb5583a5054@oss.qualcomm.com> <20260407-gfx-clk-fixes-v1-3-4bb5583a5054@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review ```c - pm_runtime_put(dev); + pm_runtime_put_sync(dev); ``` **Concern: This is a broad change affecting all `use_rpm` clock controllers.** The `qcom_cc_really_probe()` function is shared infrastructure used by every Qualcomm clock controller with `use_rpm = true`. The commit message motivates this change specifically for gxclkctl/IFPC, but the change applies globally. For most clock controllers, the async `pm_runtime_put()` is preferable because it avoids blocking probe unnecessarily. The synchronous variant adds latency to every such probe call. If the requirement is specific to gxclkctl (which Patch 4 then disables RPM on), consider whether this should be scoped more narrowly -- perhaps by adding a flag to `qcom_cc_desc` to opt into synchronous put, or by doing the sync in the gxclkctl probe itself. Also, no Fixes tag is present. Is this a standalone fix or only needed as a prerequisite for Patch 4? --- Generated by Claude Code Patch Reviewer