From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: lib/fonts: Provide helpers for calculating glyph pitch and size Date: Sun, 12 Apr 2026 13:55:02 +1000 Message-ID: In-Reply-To: <20260407092555.58816-4-tzimmermann@suse.de> References: <20260407092555.58816-1-tzimmermann@suse.de> <20260407092555.58816-4-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Verdict: Good cleanup, one minor doc nit.** Introduces `font_glyph_pitch(width)` and `font_glyph_size(width, vpitch)` as static inlines in ``, replacing open-coded `(width + 7) / 8` and `((width + 7) / 8) * height` throughout fbcon. The replacement is mechanical and correct throughout all callers (`fbcon_ccw.c`, `fbcon_cw.c`, `fbcon_ud.c`, `fbcon_rotate.c`, `fonts.c`, `vt.c`). **Minor nit**: The kernel-doc for `font_glyph_pitch` says "if width is 14 bytes per scanline" -- this should say "14 **bits** per scanline", since the `width` parameter is in bits and the return value is in bytes. --- --- Generated by Claude Code Patch Reviewer