From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tyr: Use register! macro for JOB_CONTROL
Date: Sun, 12 Apr 2026 10:45:09 +1000
Message-ID: <review-patch3-20260409-b4-tyr-use-register-macro-v5-v5-3-8abfff8a0204@collabora.com>
In-Reply-To: <20260409-b4-tyr-use-register-macro-v5-v5-3-8abfff8a0204@collabora.com>
References: <20260409-b4-tyr-use-register-macro-v5-v5-0-8abfff8a0204@collabora.com> <20260409-b4-tyr-use-register-macro-v5-v5-3-8abfff8a0204@collabora.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Replaces four `Register<OFFSET>` constants and one `bit_u32` constant with typed `register!` definitions in a `job_control` module.

```rust
pub(crate) JOB_IRQ_RAWSTAT(u32) @ 0x1000 {
    30:0    csg;
    31:31   glb => bool;
}
```

The CSG field is 31 bits wide (bits 30:0), correctly matching the hardware where each bit corresponds to one CSG slot. The GLB bit at 31 is correctly typed as bool. The four register definitions (RAWSTAT, CLEAR, MASK, STATUS) mirror the same field layout, which is correct.

The old `JOB_IRQ_GLOBAL_IF` (`bit_u32(31)`) is replaced by the `glb` field accessor. The `bits::bit_u32` import is also removed since it was the last user. Clean.

No issues with this patch.

---
Generated by Claude Code Patch Reviewer