From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/display/intel_dp: Drop redundant intel_dp_aux_fini() on init failure Date: Sun, 12 Apr 2026 10:51:24 +1000 Message-ID: In-Reply-To: <20260409-feat_link_cap-v1-3-7069e8199ce2@bootlin.com> References: <20260409-feat_link_cap-v1-0-7069e8199ce2@bootlin.com> <20260409-feat_link_cap-v1-3-7069e8199ce2@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Correct. The `fail:` label already calls `drm_connector_cleanup()` which triggers encoder destroy paths, and `intel_dp_encoder_flush_work()` (called from both `intel_dp_encoder_destroy()` and `intel_ddi_encoder_destroy()`) already calls `intel_dp_aux_fini()`. The explicit call was redundant. --- Generated by Claude Code Patch Reviewer