From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/gem/shmem: Export drm_gem_shmem_get_pages_sgt_locked() Date: Sun, 12 Apr 2026 12:01:18 +1000 Message-ID: In-Reply-To: <20260409001559.622026-4-lyude@redhat.com> References: <20260409001559.622026-1-lyude@redhat.com> <20260409001559.622026-4-lyude@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Straightforward: makes the existing static function public, adds a `dma_res= v_assert_held` check, and exports it. **Doc comment title is wrong:** The kerneldoc says: ```c /** * drm_gem_shmem_get_sg_table - Under dma_resv lock, provide a scatter/gath= er table of ``` It should say `drm_gem_shmem_get_pages_sgt_locked`, not `drm_gem_shmem_get_= sg_table`. The latter is a different function. **Typo:** "A poitner" =E2=86=92 "A pointer". Otherwise clean and correct. --- --- Generated by Claude Code Patch Reviewer