From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/pagemap: Split drm_pagemap_migrate_map_pages into device / system Date: Sun, 12 Apr 2026 09:24:51 +1000 Message-ID: In-Reply-To: <20260410205929.3914474-4-matthew.brost@intel.com> References: <20260410205929.3914474-1-matthew.brost@intel.com> <20260410205929.3914474-4-matthew.brost@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Good preparatory refactor. Splitting the combined `drm_pagemap_migrate_map_pages` into `drm_pagemap_migrate_map_device_private_pages` and `drm_pagemap_migrate_map_system_pages` cleanly separates concerns and makes the IOVA addition in Patch 4 more localized. The addition of `WARN_ON_ONCE(!is_device_private_page(page))` in the device-private helper and `WARN_ON_ONCE(is_device_private_page(page))` in the system helper are good defensive checks. The `drm_pagemap_migrate_sys_to_dev` signature change (dropping `mdetails`) is correct since `mdetails` was only needed for the device-private page logic (`can_migrate_same_pagemap`), and system pages don't need it. **Minor doc issue**: The new kerneldoc for `drm_pagemap_migrate_map_system_pages` says: ``` * corresponding page, and stores the DMA address in the provided @dma_addr * array. ``` The parameter is `@pagemap_addr`, not `@dma_addr`. Patch 5 fixes this exact same issue in the unmap function but misses it in this map function's doc. --- --- Generated by Claude Code Patch Reviewer