From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: io: use pointer types instead of address
Date: Thu, 23 Apr 2026 08:25:45 +1000 [thread overview]
Message-ID: <review-patch3-20260421-io_projection-v2-3-4c251c692ef4@garyguo.net> (raw)
In-Reply-To: <20260421-io_projection-v2-3-4c251c692ef4@garyguo.net>
Patch Review
The biggest refactor: replaces `addr() -> usize` / `maxsize() -> usize` with `as_ptr() -> *mut Self::Type` on the `Io` trait, and makes `IoCapable` take `*mut T` instead of `usize`. This eliminates `IoKnownSize` (kept as a blanket impl for compatibility).
The PCI config space handling is notable. Since PCI config space uses offsets not real pointers, null pointers with size metadata are used:
```rust
fn null_ptr_from_size(size: ConfigSpaceSize) -> *mut Self::Region {
core::ptr::slice_from_raw_parts_mut(core::ptr::null_mut::<u8>(), size.into_raw())
as *mut Self::Region
}
```
This is documented as intentional since `IoCapable` impls for PCI config space only use `address.addr()` (the offset), never dereferencing the pointer. The `io_addr` method now uses `wrapping_byte_add` which is appropriate for potentially-null pointers.
One minor observation: the `io_addr_assert` method now uses `build_assert!` with `Self::Type::MIN_SIZE` -- this means it checks against the compile-time minimum, while `io_addr` checks against the runtime `KnownSize::size(ptr)`. This is consistent with the intent (compile-time vs runtime bounds checking).
The `IoKnownSize` deprecation is handled gracefully with a blanket impl and `#[doc(hidden)]`.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-22 22:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 14:56 [PATCH v2 00/11] rust: I/O type generalization and projection Gary Guo
2026-04-21 14:56 ` [PATCH v2 01/11] rust: io: generalize `MmioRaw` to pointer to arbitrary type Gary Guo
2026-04-22 22:25 ` Claude review: " Claude Code Review Bot
2026-04-21 14:56 ` [PATCH v2 02/11] rust: io: generalize `Mmio` " Gary Guo
2026-04-22 22:25 ` Claude review: " Claude Code Review Bot
2026-04-21 14:56 ` [PATCH v2 03/11] rust: io: use pointer types instead of address Gary Guo
2026-04-22 22:25 ` Claude Code Review Bot [this message]
2026-04-21 14:56 ` [PATCH v2 04/11] rust: io: add missing safety requirement in `IoCapable` methods Gary Guo
2026-04-22 22:25 ` Claude review: " Claude Code Review Bot
2026-04-21 14:56 ` [PATCH v2 05/11] rust: io: restrict untyped IO access and `register!` to `Region` Gary Guo
2026-04-22 22:25 ` Claude review: " Claude Code Review Bot
2026-04-21 14:56 ` [PATCH v2 06/11] rust: io: add view type Gary Guo
2026-04-22 22:25 ` Claude review: " Claude Code Review Bot
2026-04-21 14:56 ` [PATCH v2 07/11] rust: dma: add methods to unsafely create reference from subview Gary Guo
2026-04-22 22:25 ` Claude review: " Claude Code Review Bot
2026-04-21 14:56 ` [PATCH v2 08/11] rust: io: add `read_val` and `write_val` function on I/O view Gary Guo
2026-04-22 22:25 ` Claude review: " Claude Code Review Bot
2026-04-21 14:56 ` [PATCH v2 09/11] gpu: nova-core: use I/O projection for cleaner encapsulation Gary Guo
2026-04-22 22:25 ` Claude review: " Claude Code Review Bot
2026-04-21 14:56 ` [PATCH v2 10/11] rust: dma: drop `dma_read!` and `dma_write!` API Gary Guo
2026-04-22 22:25 ` Claude review: " Claude Code Review Bot
2026-04-21 14:56 ` [PATCH v2 11/11] rust: io: add copying methods Gary Guo
2026-04-22 22:25 ` Claude review: " Claude Code Review Bot
2026-04-22 22:25 ` Claude review: rust: I/O type generalization and projection Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260421-io_projection-v2-3-4c251c692ef4@garyguo.net \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox