From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: do not import firmware commands into GSP command module Date: Thu, 23 Apr 2026 08:52:55 +1000 Message-ID: In-Reply-To: <20260421-nova-unload-v2-3-2fe54963af8b@nvidia.com> References: <20260421-nova-unload-v2-0-2fe54963af8b@nvidia.com> <20260421-nova-unload-v2-3-2fe54963af8b@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **File:** `drivers/gpu/nova-core/gsp/commands.rs` Changes `fw::{commands::*, MsgFunction}` to `fw::{self, MsgFunction}` and q= ualifies all former wildcard-imported types with `fw::commands::`. Also swi= tches several direct type references to `Self::Command::` where applicable = (e.g., `GspSetSystemInfo::init(...)` becomes `Self::Command::init(...)`). This is purely a namespace hygiene change. The commit message explains the = motivation well: the wildcard import made it ambiguous which layer (fw vs. = GSP) a command type belonged to, and prevented creating GSP-level commands = with the same name as their firmware counterparts =E2=80=94 which is exactl= y what patch 4 does with `UnloadingGuestDriver`. The `Self::Command::` pattern is idiomatic and reduces coupling. No issues. --- Generated by Claude Code Patch Reviewer