From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/gem/shmem: Export drm_gem_shmem_get_pages_sgt_locked()
Date: Thu, 23 Apr 2026 08:09:06 +1000
Message-ID: <review-patch3-20260421234234.638503-4-lyude@redhat.com>
In-Reply-To: <20260421234234.638503-4-lyude@redhat.com>
References: <20260421234234.638503-1-lyude@redhat.com> <20260421234234.638503-4-lyude@redhat.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Verdict: Looks good.**

This promotes `drm_gem_shmem_get_pages_sgt_locked()` from `static` to exported, adds a `dma_resv_assert_held()` check, and adds proper kerneldoc. Clean and correct.

```c
+	dma_resv_assert_held(shmem->base.resv);
+
 	if (shmem->sgt)
 		return shmem->sgt;
```

The assert is a valuable addition. The documentation is clear. No issues.

---

---
Generated by Claude Code Patch Reviewer