From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: remove unneeded get_gsp_info proxy function
Date: Thu, 23 Apr 2026 07:34:42 +1000
Message-ID: <review-patch3-20260422-nova-unload-v3-3-1d2c81bd3ced@nvidia.com>
In-Reply-To: <20260422-nova-unload-v3-3-1d2c81bd3ced@nvidia.com>
References: <20260422-nova-unload-v3-0-1d2c81bd3ced@nvidia.com> <20260422-nova-unload-v3-3-1d2c81bd3ced@nvidia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Status: Looks good**

Straightforward removal of a trivial wrapper:

```rust
-pub(crate) fn get_gsp_info(cmdq: &Cmdq, bar: &Bar0) -> Result<GetGspStaticInfoReply> {
-    cmdq.send_command(bar, GetGspStaticInfo)
-}
```

Replaced by direct call at the call site:

```rust
-        let info = commands::get_gsp_info(&self.cmdq, bar)?;
+        let info = self.cmdq.send_command(bar, commands::GetGspStaticInfo)?;
```

`GetGspStaticInfo` is made `pub(crate)` to support this. The wrapper added no value beyond the direct `send_command` call. Good cleanup.

---
Generated by Claude Code Patch Reviewer