From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: Clean up S6E3HA2 config dependencies and fill help text Date: Thu, 23 Apr 2026 07:47:41 +1000 Message-ID: In-Reply-To: <20260422-panel-clean-up-kconfig-dep-v1-3-d825e9ffe911@ixit.cz> References: <20260422-panel-clean-up-kconfig-dep-v1-0-d825e9ffe911@ixit.cz> <20260422-panel-clean-up-kconfig-dep-v1-3-d825e9ffe911@ixit.cz> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Author:** David Heidelberg **Status:** Has issues that should be fixed. **Issue 1 (subject line error):** The subject says "S6E3HA**2**" but the diff modifies `DRM_PANEL_SAMSUNG_S6E3HA**8**`: ``` config DRM_PANEL_SAMSUNG_S6E3HA8 tristate "Samsung S6E3HA8 DSI video mode panel" - depends on OF + depends on OF && GPIOLIB ``` The Fixes tag also correctly references S6E3HA8: ``` Fixes: 779679d3c164 ("drm/panel: Add support for S6E3HA8 panel driver") ``` The subject must be corrected to say "S6E3HA8". **Issue 2 (commit message vs. tristate mismatch):** The commit message says *"this Display IC features a DSI command-mode interface"*, which is copy-pasted from patch 1's SOFEF00 description. However, the tristate says `"Samsung S6E3HA8 DSI video mode panel"`. Checking the actual driver, I see the mode_flags do NOT include `MIPI_DSI_MODE_VIDEO`, meaning the driver actually operates in command mode despite the tristate saying "video mode". So the commit message is arguably more accurate than the tristate, but this creates confusion. Consider updating the tristate description as well, or at minimum adjusting the commit message to note the discrepancy. **Issue 3 (missed opportunity):** The adjacent `DRM_PANEL_SAMSUNG_S6E3HA2` config entry has identical problems (selects `VIDEOMODE_HELPERS` unnecessarily, and its driver uses `devm_gpiod_get`/`gpiod_set_value` without depending on GPIOLIB). Since the patches are numbered and chained, the S6E3HA2 entry would naturally be fixed in this same series. The actual Kconfig changes (adding GPIOLIB dependency, removing VIDEOMODE_HELPERS, adding help text) are correct and verified against the driver source. --- Generated by Claude Code Patch Reviewer