From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: misc: fastrpc: Expand context ID mask for DSP polling mode support Date: Thu, 23 Apr 2026 07:50:44 +1000 Message-ID: In-Reply-To: <20260422092409.4107093-4-ekansh.gupta@oss.qualcomm.com> References: <20260422092409.4107093-1-ekansh.gupta@oss.qualcomm.com> <20260422092409.4107093-4-ekansh.gupta@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Assessment: Correct, well explained.** Changes `GENMASK(11, 4)` to `GENMASK(15, 8)`. The commit message explains the bit layout clearly: ``` [15:8] = context ID (8 bits) [7:5] = reserved [4] = async mode bit [3:0] = PD type (4 bits) ``` This shifts the context ID up by 4 bits but the IDR still stores a compact integer and the mask handles packing/unpacking, so existing logic in `fastrpc_context_alloc`, `fastrpc_context_free`, and `fastrpc_rpmsg_callback` all continue to work correctly via `FIELD_PREP`/`FIELD_GET`. **No issues found.** Has Dmitry's Reviewed-by. --- --- Generated by Claude Code Patch Reviewer