From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: Expose total physical VRAM end from FB region info Date: Tue, 28 Apr 2026 15:31:59 +1000 Message-ID: In-Reply-To: <20260425211454.174696-4-joelagnelf@nvidia.com> References: <20260425211454.174696-1-joelagnelf@nvidia.com> <20260425211454.174696-4-joelagnelf@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `total_fb_end()` which finds the highest FB region end across all regions (including reserved). Logs total VRAM at boot. **Minor:** The `>> 20` conversion to MiB for logging implicitly assumes VRAM starts at address 0. If VRAM had a non-zero base, the log would overstate the actual VRAM size. On NVIDIA hardware this is always true, but a comment would help. --- Generated by Claude Code Patch Reviewer