From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge-connector: Use cached connector status in .get_modes() Date: Tue, 28 Apr 2026 15:25:20 +1000 Message-ID: In-Reply-To: <20260426-dw-hdmi-qp-scramb-v5-3-d778e70c317b@collabora.com> References: <20260426-dw-hdmi-qp-scramb-v5-0-d778e70c317b@collabora.com> <20260426-dw-hdmi-qp-scramb-v5-3-d778e70c317b@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review ```c - status = drm_bridge_connector_detect(connector, false); - if (status != connector_status_connected) + if (connector->status != connector_status_connected) goto no_edid; ``` The commit message correctly explains that `.get_modes()` is only called from `drm_helper_probe_single_connector_modes()`, which has already run detection and cached the result in `connector->status`. This eliminates a redundant detect call and is a prerequisite for patch 4 since `detect_ctx` requires a `drm_modeset_acquire_ctx` not available in the `get_modes` path. **Correct and well-motivated. No issues.** --- --- Generated by Claude Code Patch Reviewer