From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma-buf: heaps: system: Turn the heap into a module Date: Tue, 28 Apr 2026 14:45:01 +1000 Message-ID: In-Reply-To: <20260427-dma-buf-heaps-as-modules-v5-3-b6f5678feefc@kernel.org> References: <20260427-dma-buf-heaps-as-modules-v5-0-b6f5678feefc@kernel.org> <20260427-dma-buf-heaps-as-modules-v5-3-b6f5678feefc@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Change:** - `drivers/dma-buf/heaps/Kconfig`: `DMABUF_HEAPS_SYSTEM` changed from `bool= ` to `tristate` - `drivers/dma-buf/heaps/system_heap.c`: Adds `MODULE_DESCRIPTION("DMA-BUF = System Heap")`, `MODULE_LICENSE("GPL")`, `MODULE_IMPORT_NS("DMA_BUF")`, `MO= DULE_IMPORT_NS("DMA_BUF_HEAP")` Same pattern as the CMA heap patch. This one also adds `MODULE_DESCRIPTION`= which the CMA heap already had from a prior commit. The namespace imports = are correct =E2=80=94 this heap directly uses `mem_accounting` (at line 388= ), so the `DMA_BUF_HEAP` import is needed. Same no-`module_exit` situation applies here, correctly documented. No issues. --- Generated by Claude Code Patch Reviewer