From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: clk: qcom: common: ensure runtime PM suspend completes on probe
Date: Tue, 28 Apr 2026 15:05:23 +1000 [thread overview]
Message-ID: <review-patch3-20260427-gfx-clk-fixes-v2-3-797e54b3d464@oss.qualcomm.com> (raw)
In-Reply-To: <20260427-gfx-clk-fixes-v2-3-797e54b3d464@oss.qualcomm.com>
Patch Review
**Author:** Taniya Das
```c
- pm_runtime_put(dev);
+ pm_runtime_put_sync(dev);
```
The commit message has a minor formatting artifact: `"putV` appears to be a copy-paste error for `"put"`. Otherwise the change is straightforward and the rationale is sound -- the async `pm_runtime_put()` can race with a subsequent `pm_runtime_disable()` called by the gxclkctl probe in patch 4.
**Minor concern:** This is a generic change to `qcom_cc_really_probe()` which affects all Qualcomm clock controllers using `use_rpm`, not just gxclkctl. The commit message says "This does not have any functional impact" but `pm_runtime_put_sync()` will block in probe, which could add latency for all qcom clock controllers. This deserves a comment from the clock maintainers about whether the broader impact is acceptable, or whether this change should be scoped to gxclkctl only.
Note also that `put_rpm:` is used for both the success path and the error path. On the error path, synchronous completion may not matter. On the success path for other clock controllers, blocking unnecessarily could delay boot.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-28 5:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 6:38 [PATCH v2 0/6] qcom: Refactor GPU GX GDSC handling and IFPC behavior on A8x GPUs Taniya Das
2026-04-27 6:38 ` [PATCH v2 1/6] clk: qcom: gdsc: Add custom disable callback for GX GDSC Taniya Das
2026-04-27 13:13 ` Konrad Dybcio
2026-04-28 5:05 ` Claude review: " Claude Code Review Bot
2026-04-27 6:38 ` [PATCH v2 2/6] clk: qcom: gxclkctl: Use custom disable callback for gx_gdsc Taniya Das
2026-04-28 5:05 ` Claude review: " Claude Code Review Bot
2026-04-27 6:38 ` [PATCH v2 3/6] clk: qcom: common: ensure runtime PM suspend completes on probe Taniya Das
2026-04-27 13:17 ` Konrad Dybcio
2026-04-28 5:05 ` Claude Code Review Bot [this message]
2026-04-27 6:38 ` [PATCH v2 4/6] clk: qcom: gxclkctl: Remove GX/GMxC rail votes to align with IFPC Taniya Das
2026-04-27 13:14 ` Konrad Dybcio
2026-04-28 5:05 ` Claude review: " Claude Code Review Bot
2026-04-27 6:38 ` [PATCH v2 5/6] drm/msm/a8xx: Make a8xx_recover IFPC safe Taniya Das
2026-04-28 5:05 ` Claude review: " Claude Code Review Bot
2026-04-27 6:39 ` [PATCH v2 6/6] drm/msm/a6xx: Limit GXPD votes to recovery in A8x Taniya Das
2026-04-27 13:17 ` Konrad Dybcio
2026-04-28 5:05 ` Claude review: " Claude Code Review Bot
2026-04-28 5:05 ` Claude review: qcom: Refactor GPU GX GDSC handling and IFPC behavior on A8x GPUs Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-07 9:30 [PATCH 0/6] " Taniya Das
2026-04-07 9:30 ` [PATCH 3/6] clk: qcom: common: ensure runtime PM suspend completes on probe Taniya Das
2026-04-12 3:46 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260427-gfx-clk-fixes-v2-3-797e54b3d464@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox