From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: split BAR acquisition in unbind() Date: Tue, 28 Apr 2026 15:01:47 +1000 Message-ID: In-Reply-To: <20260427-nova-unload-v4-3-e145ccddae66@nvidia.com> References: <20260427-nova-unload-v4-0-e145ccddae66@nvidia.com> <20260427-nova-unload-v4-3-e145ccddae66@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Changes `unbind()` from using `warn_on!` + `inspect` to an early-return pat= tern with `dev_err!`: ```rust + let Ok(bar) =3D self.bar.access(dev) else { + dev_err!(dev, "failed to acquire bar for driver unbinding\n"); + return; + }; ``` This is a behavior change: previously a BAR acquisition failure would trigg= er a `WARN_ON` (which is a kernel stacktrace + taint), now it logs an error= and silently returns. For an unbind path this seems reasonable =E2=80=94 a= WARN_ON during unbind is unhelpful =E2=80=94 but **the switch from WARN_ON= to dev_err silently downgrades the severity.** This is probably intentiona= l given subsequent patches will add more logic after the BAR acquisition, b= ut worth noting. No blocking issues. --- --- Generated by Claude Code Patch Reviewer