From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Replace cross-component register accesses with helpers Date: Tue, 28 Apr 2026 14:28:32 +1000 Message-ID: In-Reply-To: <20260427155934.416502-4-karunika.choo@arm.com> References: <20260427155934.416502-1-karunika.choo@arm.com> <20260427155934.416502-4-karunika.choo@arm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Introduces `panthor_gpu_get_timestamp()`, `panthor_gpu_get_timestamp_offset()`, `panthor_gpu_get_cycle_count()`, `panthor_gpu_coherency_init()`, and `panthor_fw_ring_doorbell()` to encapsulate register accesses within the component that owns them. Callers in `panthor_drv.c`, `panthor_sched.c`, and `panthor_pwr.c` are updated to use these helpers. Good approach - `panthor_pwr_debug_info_show` now reads `ptdev->gpu_info.gpu_features` instead of hitting the GPU register directly, which is cleaner. No issues. --- Generated by Claude Code Patch Reviewer