From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/display: dmub_cmd.h: correct all kernel-doc prototype warnings Date: Tue, 28 Apr 2026 13:53:32 +1000 Message-ID: In-Reply-To: <20260427214122.784024-2-rdunlap@infradead.org> References: <20260427214122.784024-1-rdunlap@infradead.org> <20260427214122.784024-2-rdunlap@infradead.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Good to merge.** This patch adds proper `@ENUM_VALUE:` kernel-doc annotations to enum values= that were missing them, and converts a few `/**` comment blocks to plain `= /*` where no kernel-doc content was present. The changes fall into three categories: 1. **Adding `@VALUE_NAME:` tags** to existing `/**` doc comments =E2=80=94 = e.g.: ```c /** @DMUB_CMD__MALL_ACTION_ALLOW: Allows display refresh from MALL. */ ``` This follows the standard kernel-doc format for enum values. 2. **Converting `/**` to `/*`** for enums without real documentation conten= t (e.g., `dmub_shared_state_feature_id`, `mclk_switch_mode`, `dmub_idle_opt= _dc_power_state`, `dmub_phy_fsm_state`). This is the correct approach =E2= =80=94 `/**` signals kernel-doc, and if there's no actual kernel-doc conten= t, it generates warnings. 3. **Reformatting inline `/**< ... */` comments** into multi-line `/** @NAM= E: description */` blocks for `dmub_fw_boot_status_bit`. The content is pre= served; only the format changes. Minor nit: in `DMUB_FW_BOOT_STATUS_BIT_ONO_REGIONS_ENABLED`, the original c= omment said "1 if ONO regions are enabled" but the updated version drops th= e "1": ```c /** @DMUB_FW_BOOT_STATUS_BIT_ONO_REGIONS_ENABLED: if ONO regions are enable= d */ ``` All the other entries in this enum say "1 if ...". This is trivial but inco= nsistent. Overall, all three patches are clean, correct, and ready to merge. --- Generated by Claude Code Patch Reviewer