From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/mediatek: mtk_cec: Fix non-static global variable Date: Tue, 05 May 2026 11:40:57 +1000 Message-ID: In-Reply-To: <20260429-mediatek-drm-fix-sparse-warnings-v1-3-d95c4d118b83@collabora.com> References: <20260429-mediatek-drm-fix-sparse-warnings-v1-0-d95c4d118b83@collabora.com> <20260429-mediatek-drm-fix-sparse-warnings-v1-3-d95c4d118b83@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review ```c -struct platform_driver mtk_cec_driver =3D { +static struct platform_driver mtk_cec_driver =3D { ``` Correct. `mtk_cec_driver` is only used at the definition and via `module_pl= atform_driver()` in `mtk_cec.c`. The Fixes tag points to `1e914a89ab7e` whi= ch switched it to `module_platform_driver` registration =E2=80=94 this is t= he commit that made the variable no longer need external linkage, so the Fi= xes tag is appropriate. Note: unlike patches 1 and 2, this patch does not have `Reported-by: kernel= test robot` =E2=80=94 the cover letter explains these two (patches 3 and 4= ) are "two others introduced during v6.16 development cycle" that were foun= d separately. This is fine. **Reviewed-by worthy. No issues.** --- Generated by Claude Code Patch Reviewer