From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Replace the panthor_irq macro machinery by inline helpers Date: Tue, 05 May 2026 11:44:53 +1000 Message-ID: In-Reply-To: <20260429-panthor-signal-from-irq-v1-3-4b92ae4142d2@collabora.com> References: <20260429-panthor-signal-from-irq-v1-0-4b92ae4142d2@collabora.com> <20260429-panthor-signal-from-irq-v1-3-4b92ae4142d2@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Verdict: Looks good, well done.** Replaces the `PANTHOR_IRQ_HANDLER()` macro (which generated per-subsystem functions) with generic inline helpers: `panthor_irq_default_raw_handler()`, `panthor_irq_default_threaded_handler()`, `panthor_irq_suspend()`, `panthor_irq_resume()`, etc. Each subsystem now provides its own `_threaded_handler()` wrapper as a one-liner. The handler prototype change from `(struct panthor_device *, u32)` to `(struct panthor_irq *, u32)` is sensible since `panthor_irq` is what gets passed around and `ptdev` is easily extracted from it. The `panthor_irq_request()` helper with `devm_kasprintf()` for the name string is a nice improvement over the old `KBUILD_MODNAME "-" #__name` macro stringification. --- --- Generated by Claude Code Patch Reviewer