From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/adreno: rename llc_mmio to cx_misc_mmio Date: Tue, 05 May 2026 08:55:16 +1000 Message-ID: In-Reply-To: <20260502-adreno-810-v5-3-bc9fd2bb788d@pm.me> References: <20260502-adreno-810-v5-0-bc9fd2bb788d@pm.me> <20260502-adreno-810-v5-3-bc9fd2bb788d@pm.me> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Looks good** Straightforward mechanical rename of `llc_mmio` =E2=86=92 `cx_misc_mmio` an= d the accessor functions `a6xx_llc_read/write/rmw` =E2=86=92 `a6xx_cx_misc_= read/write/rmw`. The rename is well-motivated: the CX_MISC region is used f= or more than just LLCC (software fuses, TCM retention, slice info, speedbin= softfuse), so the name was misleading. The rename covers all files consistently: - `a6xx_gpu.h`: struct field and inline accessor functions - `a6xx_gpu.c`: all call sites in `a6xx_llc_activate`, `a7xx_llc_activate`,= `a6xx_llc_slices_init`, `a6xx_read_speedbin` - `a6xx_gmu.c`: TCM retention, SW fuse, cold/warm boot detection - `a8xx_gpu.c`: slice enable readback Has `Reviewed-by` from Akhil P Oommen and Konrad Dybcio. No issues found. --- --- Generated by Claude Code Patch Reviewer