From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/hdmi: switch to of_drm_get_bridge_by_endpoint() Date: Tue, 05 May 2026 08:26:08 +1000 Message-ID: In-Reply-To: <20260504-drm-bridge-alloc-getput-panel_or_bridge-v4-3-b578c3daaf10@bootlin.com> References: <20260504-drm-bridge-alloc-getput-panel_or_bridge-v4-0-b578c3daaf10@bootlin.com> <20260504-drm-bridge-alloc-getput-panel_or_bridge-v4-3-b578c3daaf10@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Good** This is one of the more complex conversions because `next_bridge` is option= al (the `-ENODEV` case means no downstream bridge, which is valid). The con= version correctly: 1. Uses `__free(drm_bridge_put)` for automatic cleanup on error paths 2. Converts `-ENODEV` to `NULL` (no bridge present, not an error) 3. Propagates other errors 4. Uses `no_free_ptr()` to transfer ownership to `hdmi->next_bridge` at the= end of probe 5. Adds `drm_bridge_put()` in the remove path The `__free(drm_bridge_put)` cleanup will correctly handle the `NULL` case = (after the `-ENODEV` =E2=86=92 `NULL` conversion) due to the `if (_T)` guar= d in `DEFINE_FREE`. --- Generated by Claude Code Patch Reviewer