From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Call poweron/poweroff from atomic enable/disable Date: Tue, 05 May 2026 07:58:55 +1000 Message-ID: In-Reply-To: <20260504191059.275928-4-jonas@kwiboo.se> References: <20260504191059.275928-1-jonas@kwiboo.se> <20260504191059.275928-4-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This removes `bridge_is_on` tracking and the `dw_hdmi_update_power()` function, relying instead on the DRM core to enable/disable the bridge at the right times via `atomic_enable`/`atomic_disable`. This is the correct approach since `drm_helper_hpd_irq_event()` will trigger the DRM core to enable/disable the bridge based on connection state. The removal of `dw_hdmi_update_power()` calls from `dw_hdmi_connector_force()` and `dw_hdmi_setup_rx_sense()` is safe since the bridge lifecycle is now fully managed by the atomic helpers. Has Reviewed-by. --- Generated by Claude Code Patch Reviewer