From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tegra: Explicitly specify PMC instance to use
Date: Thu, 07 May 2026 13:29:34 +1000
Message-ID: <review-patch3-20260506-pmc-v1-3-a6de5da7216b@nvidia.com>
In-Reply-To: <20260506-pmc-v1-3-a6de5da7216b@nvidia.com>
References: <20260506-pmc-v1-0-a6de5da7216b@nvidia.com> <20260506-pmc-v1-3-a6de5da7216b@nvidia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Converts four files: `dc.c`, `dc.h`, `gr3d.c`, `sor.c`. All conversions are straightforward.

In `sor.c`, the error path on PMC lookup failure uses `goto put_aux`:

```c
	sor->pmc = devm_tegra_pmc_get(&pdev->dev);
	if (IS_ERR(sor->pmc)) {
		err = PTR_ERR(sor->pmc);
		goto put_aux;
	}
```

Since this is placed *before* `sor->aux` is ever obtained, the `put_aux` label's `if (sor->aux)` guard prevents any actual harm. But jumping to `put_aux` when aux hasn't been set up yet is misleading -- a direct `return PTR_ERR(sor->pmc)` would be clearer and match the style of the `return -ENOMEM` just above it. Also, `dev_err_probe()` is not used here, unlike most other patches.

---
Generated by Claude Code Patch Reviewer