From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/display: use a separate helper to translate degamma curves Date: Thu, 07 May 2026 13:11:57 +1000 Message-ID: In-Reply-To: <20260506191606.15022-4-mwen@igalia.com> References: <20260506191606.15022-1-mwen@igalia.com> <20260506191606.15022-4-mwen@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Purpose**: Wires up the degamma-specific helper from patch 2 for the blen= d TF and input (degamma) TF paths in `dcn32_hwseq.c`. The change is minimal and correct. Two call sites are updated: 1. **Blend TF** (line 493=E2=86=92): `cm3_helper_translate_curve_to_hw_form= at` =E2=86=92 `cm3_helper_translate_curve_to_degamma_hw_format` for `TF_TYP= E_DISTRIBUTED_POINTS` blend curves. The degamma helper doesn't take a `dc_c= ontext` or `fixpoint` parameter, which is fine =E2=80=94 it doesn't need th= em. 2. **Input TF / degamma** (line 553=E2=86=92): Same substitution for `in_tr= ansfer_func`. **Observation**: The shaper path (around line 516 in the unmodified code) i= s intentionally left using `cm3_helper_translate_curve_to_hw_format`, since= shapers are pre-3DLUT (linear=E2=86=92encoded) and need the regamma-style = segmentation. This matches the cover letter's design. **No issues found.** --- Generated by Claude Code Patch Reviewer