From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Call poweron/poweroff from atomic enable/disable Date: Sat, 16 May 2026 16:21:41 +1000 Message-ID: In-Reply-To: <20260510124111.1226584-4-jonas@kwiboo.se> References: <20260510124111.1226584-1-jonas@kwiboo.se> <20260510124111.1226584-4-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Removes the `dw_hdmi_update_power()` indirection and the `bridge_is_on` flag, calling `dw_hdmi_poweron()`/`dw_hdmi_poweroff()` directly from the atomic enable/disable paths. The old `dw_hdmi_update_power()` was trying to handle power state from both atomic ops *and* the hotplug IRQ handler. Since `drm_helper_hpd_irq_event()` already triggers enable/disable as needed, the IRQ-path power management was redundant. Double-call safety is preserved because `dw_hdmi_poweroff()` checks `hdmi->phy.enabled` before calling `phy->ops->disable()`. Also removes the `dw_hdmi_update_power()` call from `dw_hdmi_setup_rx_sense()` and `dw_hdmi_connector_force()`. No issues. --- Generated by Claude Code Patch Reviewer