From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/imagination: Rename FW booted to FW initialised
Date: Sat, 16 May 2026 14:11:25 +1000
Message-ID: <review-patch3-20260512-b4-context_reset-v1-3-439bee96ed83@imgtec.com>
In-Reply-To: <20260512-b4-context_reset-v1-3-439bee96ed83@imgtec.com>
References: <20260512-b4-context_reset-v1-0-439bee96ed83@imgtec.com> <20260512-b4-context_reset-v1-3-439bee96ed83@imgtec.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Verdict: Build breakage**

This patch is described as a pure rename (`booted` =E2=86=92 `initialised`)=
 but it silently changes function call arguments in `pvr_power.c`, creating=
 a **compile error**.

In `pvr_power_device_suspend()`, the diff changes:
```c
-		err =3D pvr_power_fw_disable(pvr_dev, false, true);
+		err =3D pvr_power_fw_disable(pvr_dev, false);
```

In `pvr_power_device_resume()`:
```c
-		err =3D pvr_power_fw_enable(pvr_dev, true);
+		err =3D pvr_power_fw_enable(pvr_dev);
```

But the function signatures are *not* updated:
```c
pvr_power_fw_disable(struct pvr_device *pvr_dev, bool hard_reset, bool rpm_=
suspend)  // 3 params
pvr_power_fw_enable(struct pvr_device *pvr_dev, bool rpm_resume)  // 2 para=
ms
```

And other call sites in `pvr_power_reset()` still use the original argument=
 count:
```c
err =3D pvr_power_fw_disable(pvr_dev, hard_reset, false);  // 3 args
err =3D pvr_power_fw_enable(pvr_dev, false);  // 2 args
```

This means the patch will fail to compile. It looks like the patch was gene=
rated against a different tree where `pvr_power_fw_disable`/`pvr_power_fw_e=
nable` already had reduced parameter lists, or unrelated changes were accid=
entally folded in.

**Fix:** Either keep the original argument counts (just do the `booted` =E2=
=86=92 `initialised` rename), or include the function signature changes and=
 update all call sites consistently. If the intent is to remove the `rpm_su=
spend`/`rpm_resume` parameters entirely, that should be a separate patch wi=
th its own justification.

---
Generated by Claude Code Patch Reviewer