From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/atomic: Drop drm_private_obj.state assignment from create_state Date: Sat, 16 May 2026 13:22:52 +1000 Message-ID: In-Reply-To: <20260512-drm-mode-config-init-v4-3-591dfdcc1bf9@kernel.org> References: <20260512-drm-mode-config-init-v4-0-591dfdcc1bf9@kernel.org> <20260512-drm-mode-config-init-v4-3-591dfdcc1bf9@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Removes the redundant `obj->state = state` from `__drm_atomic_helper_private_obj_create_state()`, since the caller `drm_atomic_private_obj_init()` does this assignment anyway. The commit message correctly explains the intent to keep `atomic_create_state` side-effect-free. The `Fixes:` tag is appropriate since the original implementation violated the documented expectation. No issues. --- Generated by Claude Code Patch Reviewer