From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: arm-smmu: Update the description for Glymur GPU SMMU Date: Sat, 16 May 2026 14:42:42 +1000 Message-ID: In-Reply-To: <20260512-glymur-gpu-dt-v3-3-84232dc21c03@oss.qualcomm.com> References: <20260512-glymur-gpu-dt-v3-0-84232dc21c03@oss.qualcomm.com> <20260512-glymur-gpu-dt-v3-3-84232dc21c03@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Change:** Extends the `qcom,sm8750-smmu-500` binding block to also cover `qcom,glymur-smmu-500` by converting the `const` to an `enum`. This makes sense -- Glymur uses the same single "hlos" vote clock as sm8750. The YAML change is structurally correct: replacing `- const: qcom,sm8750-smmu-500` with a 2-element enum preserving sort order. **Observation:** The commit message says "Add the interconnects property to the common SMMU properties" but the diff doesn't add any interconnects property -- that was apparently dropped per the v3 changelog ("Remove interconnect property from adreno smmu dt and the binding doc"). The commit message needs updating to match the actual change. **Verdict:** The code change is correct but the **commit message is stale/misleading** -- it describes v2 content that was removed. Should be updated to something like "Extend the sm8750 GPU SMMU clock constraints to also cover Glymur, which uses the same single 'hlos' vote clock." --- --- Generated by Claude Code Patch Reviewer