From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Replace the panthor_irq macro machinery by inline helpers Date: Sat, 16 May 2026 13:32:45 +1000 Message-ID: In-Reply-To: <20260512-panthor-signal-from-irq-v2-3-95c614a739cb@collabora.com> References: <20260512-panthor-signal-from-irq-v2-0-95c614a739cb@collabora.com> <20260512-panthor-signal-from-irq-v2-3-95c614a739cb@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **R-b: Steven Price** Large but mechanical refactoring. The `PANTHOR_IRQ_HANDLER(__name, __handle= r)` macro is replaced by: - `panthor_irq_default_raw_handler()` =E2=80=94 shared raw handler - `panthor_irq_default_threaded_handler()` =E2=80=94 takes a callback - `panthor_irq_suspend()` / `panthor_irq_resume()` / `panthor_irq_enable_ev= ents()` / `panthor_irq_disable_events()` =E2=80=94 no longer name-stamped - `panthor_irq_request()` =E2=80=94 replaces `panthor_request_xxx_irq()` The IRQ handler callbacks change signature from `void (*)(struct panthor_de= vice *, u32)` to `void (*)(struct panthor_irq *, u32)`. Each call site (`pa= nthor_fw.c`, `panthor_gpu.c`, `panthor_mmu.c`, `panthor_pwr.c`) is updated = to extract `ptdev` from `pirq->ptdev`. This is a sensible change since `pir= q` is the natural data context. One note: the `panthor_irq_request()` adds a `devm_kasprintf()` call before= `panthor_irq_resume()`. The v2 changelog notes this was fixed per review f= eedback (moved before `panthor_irq_resume()`). Good. The forward declaration that existed for `panthor_mmu_irq_handler` / `PANTH= OR_IRQ_HANDLER(mmu, ...)` in `panthor_mmu.c` is cleanly eliminated since th= e threaded handler wrapper is now a small static function defined after the= actual handler. No concerns. --- --- Generated by Claude Code Patch Reviewer