From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: driver core: platform: provide platform_device_add_software_node() Date: Sat, 16 May 2026 13:28:30 +1000 Message-ID: In-Reply-To: <20260512-swnode-remove-on-dev-unreg-v5-3-0035eff63812@oss.qualcomm.com> References: <20260512-swnode-remove-on-dev-unreg-v5-0-0035eff63812@oss.qualcomm.com> <20260512-swnode-remove-on-dev-unreg-v5-3-0035eff63812@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review A thin wrapper around `device_add_software_node()`: ```c int platform_device_add_software_node(struct platform_device *pdev, const struct software_node *swnode) { return device_add_software_node(&pdev->dev, swnode); } ``` The documentation is clear, and the function follows the existing pattern of `platform_device_add_data()` and `platform_device_add_resources()`. The note added to `platform_device_alloc()`'s doc about not manually assigning `swnode`/`resources`/`platform_data` is helpful. Also updates `platform_device_register_full()` to use the new helper internally, which is consistent. No issues. --- Generated by Claude Code Patch Reviewer