From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/doc: Document DRM_WEDGE_RECOVERY_COLD_RESET recovery method Date: Sat, 16 May 2026 13:17:49 +1000 Message-ID: In-Reply-To: <20260512132614.1793083-10-mallesh.koujalagi@intel.com> References: <20260512132614.1793083-7-mallesh.koujalagi@intel.com> <20260512132614.1793083-10-mallesh.koujalagi@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The documentation is generally good. A few observations: **Recovery script lacks error handling** The example `cold-reset.sh` script does not check the return status of critical operations: ```sh echo 1 > /sys/bus/pci/devices/$DEVICE/remove echo 0 > /sys/bus/pci/slots/$SLOT/power sleep 2 echo 1 > /sys/bus/pci/slots/$SLOT/power ``` If `remove` fails or `power` writes fail, the script continues silently. While this is an example script and not production code, adding basic error checks (`set -e` or explicit checks) would be good practice for documentation that users will copy. **Minor: the "No slot found" case has no guidance** ```sh else echo "No slot found" fi ``` When no slot is found, the script gives no guidance on what to do. A comment suggesting a system-level power cycle or BMC-assisted reset would help operators. **Table update is correct:** ``` cold-reset remove device + slot power cycle + rescan ``` This matches the `#define` comment from patch 2. --- --- Generated by Claude Code Patch Reviewer